Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ - feat: implemented the audit log addition #533

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Dec 5, 2024

closes #498

  • Checked that the entries wit the same timestamps are all present

Depends on Admin UI update (maykinmedia/admin-ui#155)

@Xaohs Xaohs requested a review from svenvandescheur December 5, 2024 16:04
@Xaohs Xaohs marked this pull request as ready for review December 5, 2024 16:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (a7bc9c9) to head (df5453b).

Files with missing lines Patch % Lines
...estructionListAuditLog/DestructionListAuditLog.tsx 85.71% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #533       +/-   ##
===========================================
- Coverage   91.07%   80.32%   -10.75%     
===========================================
  Files         110      204       +94     
  Lines        3495     5596     +2101     
  Branches        0      560      +560     
===========================================
+ Hits         3183     4495     +1312     
- Misses        312     1101      +789     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenvandescheur
Copy link
Contributor

I've made some more change to admin-ui, lets have a look at this together to get this in :)

@Xaohs Xaohs force-pushed the isuse/#498-attributetable branch from f28a895 to ff2026e Compare December 10, 2024 14:42
@Xaohs Xaohs force-pushed the isuse/#498-attributetable branch from 3f55626 to df5453b Compare December 10, 2024 14:56
@svenvandescheur svenvandescheur merged commit 546e245 into main Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kunnen zien van welke zaken na beoordeling uitzondering van vernietiging niet is overgenomen
3 participants