Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ #392 - populate date range filter based on url #413

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Conversation

svenvandescheur
Copy link
Contributor

Requires release of: maykinmedia/admin-ui#146
Closes #392

@svenvandescheur svenvandescheur requested a review from Xaohs October 10, 2024 09:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.04%. Comparing base (b3a214d) to head (6e1566b).

Files with missing lines Patch % Lines
...ges/destructionlist/detail/hooks/useFormDialog.tsx 0.00% 6 Missing ⚠️
...s/e2e/features/test_feature_list_process_review.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   78.08%   78.04%   -0.04%     
==========================================
  Files         256      256              
  Lines        8167     8171       +4     
  Branches      170      170              
==========================================
  Hits         6377     6377              
- Misses       1639     1643       +4     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenvandescheur svenvandescheur requested review from SilviaAmAm and removed request for Xaohs October 11, 2024 08:42
Copy link
Collaborator

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works 🎉

Potential improvement for the future: don't allow negative numbers. But it doesn't crash, so good for now.

@svenvandescheur svenvandescheur merged commit 5857064 into main Oct 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Het selecteren van een datumrange op archiefactiedatum werkt niet goed
3 participants