Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#390] Refactor backend to use Django permissions #400

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

Partially fixes #390

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 95.84906% with 11 lines in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (c29d146) to head (565067f).

Files with missing lines Patch % Lines
...ion/tests/e2e/features/test_feature_list_review.py 0.00% 4 Missing ⚠️
...c/openarchiefbeheer/destruction/tests/factories.py 90.90% 2 Missing ⚠️
...ckend/src/openarchiefbeheer/utils/tests/gherkin.py 0.00% 2 Missing ⚠️
backend/src/openarchiefbeheer/accounts/managers.py 92.30% 1 Missing ⚠️
.../src/openarchiefbeheer/accounts/tests/factories.py 90.90% 1 Missing ⚠️
...s/e2e/features/test_feature_list_process_review.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #400       +/-   ##
===========================================
+ Coverage   76.63%   89.62%   +12.99%     
===========================================
  Files         247      171       -76     
  Lines        7814     6506     -1308     
  Branches      180        0      -180     
===========================================
- Hits         5988     5831      -157     
+ Misses       1663      675      -988     
+ Partials      163        0      -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the refactor/390-use-django-permissions branch 2 times, most recently from 10b5f9e to 1d02e01 Compare October 1, 2024 13:26
@SilviaAmAm SilviaAmAm marked this pull request as draft October 1, 2024 13:31
@SilviaAmAm SilviaAmAm force-pushed the refactor/390-use-django-permissions branch from 1d02e01 to 565067f Compare October 1, 2024 13:35
@SilviaAmAm SilviaAmAm marked this pull request as ready for review October 1, 2024 14:40
This was referenced Oct 2, 2024
@SilviaAmAm SilviaAmAm merged commit aac3412 into main Oct 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC koppeling maken
3 participants