Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#557] Add download endpoint #576

Merged
merged 15 commits into from
Jan 9, 2025
Merged

[#557] Add download endpoint #576

merged 15 commits into from
Jan 9, 2025

Conversation

SilviaAmAm
Copy link
Collaborator

Partly fixes #557

@SilviaAmAm SilviaAmAm marked this pull request as draft December 23, 2024 16:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.12346% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.01%. Comparing base (7ba0203) to head (af36cc1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../src/openarchiefbeheer/destruction/api/viewsets.py 87.50% 4 Missing ⚠️
...ackend/src/openarchiefbeheer/destruction/models.py 91.66% 2 Missing ⚠️
frontend/src/pages/landing/Landing.tsx 85.71% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   84.19%   84.01%   -0.19%     
==========================================
  Files         214      214              
  Lines        5772     5886     +114     
  Branches      586      599      +13     
==========================================
+ Hits         4860     4945      +85     
- Misses        912      941      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the feature/557-add-download-endpoint branch 3 times, most recently from 3f982fb to 08e2c45 Compare December 24, 2024 14:09
@SilviaAmAm SilviaAmAm marked this pull request as ready for review December 24, 2024 14:28
svenvandescheur
svenvandescheur requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 suggestion, feel free to ignore if you disagree

backend/src/openarchiefbeheer/destruction/utils.py Outdated Show resolved Hide resolved
@svenvandescheur svenvandescheur force-pushed the feature/557-add-download-endpoint branch from a727120 to eab64c2 Compare January 2, 2025 13:27
@svenvandescheur
Copy link
Contributor

I've added an initial frontend setup, but I'm having difficulties validating/testing. Can you add an e2e tests?

@SilviaAmAm SilviaAmAm force-pushed the feature/557-add-download-endpoint branch 2 times, most recently from ef5cfb9 to 71cab41 Compare January 6, 2025 12:57
@svenvandescheur svenvandescheur force-pushed the feature/557-add-download-endpoint branch 2 times, most recently from da91843 to d75c5a5 Compare January 9, 2025 12:12
@svenvandescheur
Copy link
Contributor

@SilviaAmAm wil jij deze reviewen?

SilviaAmAm
SilviaAmAm commented Jan 9, 2025
View reviewed changes
Copy link
Collaborator Author

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few questions

frontend/src/pages/landing/Landing.tsx Show resolved Hide resolved
frontend/src/pages/landing/Landing.tsx Outdated Show resolved Hide resolved
backend/src/openarchiefbeheer/conf/base.py
Comment on lines +90 to +91
GEOS_LIBRARY_PATH = config("GEOS_LIBRARY_PATH", None)
GDAL_LIBRARY_PATH = config("GDAL_LIBRARY_PATH", None)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For generating the docs, it's a Mac thing where, when installed with brew (package manager) certain system libraries may have non-standard paths. This allows to configure them using a .env, similar to: open-zaak/open-zaak@6cbb045

@svenvandescheur svenvandescheur force-pushed the feature/557-add-download-endpoint branch from d75c5a5 to 7842e25 Compare January 9, 2025 13:08
@svenvandescheur svenvandescheur force-pushed the feature/557-add-download-endpoint branch from 7842e25 to af36cc1 Compare January 9, 2025 13:19
@svenvandescheur svenvandescheur merged commit 8ab7de9 into main Jan 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvandescheur svenvandescheur svenvandescheur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

De definitieve vernietigde meta moet buiten het systeem geëxporteerd kunnen worden
3 participants
@SilviaAmAm @codecov-commenter @svenvandescheur