Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#485] tokenauth setup configuration #494

Merged

Conversation

danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Dec 16, 2024

Fixes #485
Without permissions

@joeribekker
Copy link
Member

We can split off permissions so this can already be merged, which results in a working yaml file (although every token has superuser permissions for now).

@danielmursa-dev danielmursa-dev changed the title [#485] Merge closed branch [#485] tokenauth setup configuration Dec 16, 2024
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor and optional nitpicks, otherwise LGTM.

docs/installation/config_cli.rst Show resolved Hide resolved
src/objects/token/models.py Show resolved Hide resolved
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about an example in data.yml, looks good otherwise

src/objects/conf/base.py Show resolved Hide resolved
@danielmursa-dev danielmursa-dev merged commit 64fa395 into master Dec 19, 2024
14 checks passed
@danielmursa-dev danielmursa-dev deleted the feature/485-token-permissions-setup-configuration branch December 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Token configuration via django-setup-configuration
4 participants