Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#484] Notification channel setup config #491

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Dec 12, 2024

Fixes #484

Changes

Allows configuring the NotificationConfigurationModel through django-setup-configuration

Edit: requires https://github.com/maykinmedia/notifications-api-common/pull/22/files (and a release of that?)

Certain steps (e.g loading sites, tokens, services) will be replaced
through separate branches. Those branches will branch from this branch.
@SonnyBA SonnyBA force-pushed the feature/484-notification-channel-setup-config branch from eebf53d to 22b040d Compare December 13, 2024 10:58
@SonnyBA SonnyBA changed the base branch from feature/467-objecttypes-setup-config to master December 13, 2024 11:00
@SonnyBA SonnyBA marked this pull request as ready for review December 13, 2024 11:00
@SonnyBA SonnyBA self-assigned this Dec 13, 2024
@SonnyBA
Copy link
Contributor Author

SonnyBA commented Dec 13, 2024

This PR shares commit fa0c34f with #492 and #490. Commit 71fae22 is also shared with #492.

@SonnyBA SonnyBA force-pushed the feature/484-notification-channel-setup-config branch from 22b040d to beadd61 Compare December 13, 2024 11:10
@SonnyBA SonnyBA merged commit 2604513 into master Dec 13, 2024
14 checks passed
@SonnyBA SonnyBA deleted the feature/484-notification-channel-setup-config branch December 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Notification-configuration + Channel creation via django-setup-configuration
3 participants