👷 check OAF version on PRs #460
Conversation
|
Needs #458 to be merged |
Coperh
force-pushed
the
feature/check-oaf-on-pr
branch
from
3c72530 to
8afeb04
Compare
|
Should I pin pip-tools or should I add it to the check OAF version action? |
|
Why should it be pinned? It is currently added through |
|
About this comment: maykinmedia/open-klant#255 (comment) IF there is a stable branch, you might want to keep OAF at a certain version, so you might only want to keep master up to date. |
It currently uses the latest version of setup-tools and does not use the requirements file at all. It does make sense to use the requirements file since that's what devs should use anyway. |
Coperh
force-pushed
the
feature/check-oaf-on-pr
branch
from
b919526 to
332c18c
Compare
.github/workflows/oaf-check.yml
Outdated
| - name: Install dependencies | ||
| run: pip install -U pip-tools | ||
| run: pip install -r requirements/dev.txt # use the same pip-tools as dev |
There was a problem hiding this comment.
We could do something like this to avoid installing unnecessary dependencies, pip isn't the fastest
pip install $(grep "pip-tools==" requirements/dev.txt)
Coperh
force-pushed
the
feature/check-oaf-on-pr
branch
from
332c18c to
8b764d2
Compare
Fixes maykinmedia/open-api-framework#44