✨[#414] add in operator to API #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coperh
commented
Aug 27, 2024
| data={"name": "demo3"}, object__object_type=self.object_type | ||
| ) | ||
|
|
||
| response = self.client.get(self.url, {"data_attrs": "name__in__demo1|demo2"}) |
There was a problem hiding this comment.
Don't really like this format, but I cannot think of a better one. The comma is already used for multiple attributes.
There was a problem hiding this comment.
Hmm yeah, not sure what alternatives there are
Coperh
force-pushed
the
feature/414-in-operator
branch
from
d526b8a to
1522017
Compare
stevenbal
requested changes
Aug 29, 2024
| data={"name": "demo3"}, object__object_type=self.object_type | ||
| ) | ||
|
|
||
| response = self.client.get(self.url, {"data_attrs": "name__in__demo1|demo2"}) |
There was a problem hiding this comment.
Hmm yeah, not sure what alternatives there are
Co-authored-by: Steven Bal <[email protected]>
Coperh
force-pushed
the
feature/414-in-operator
branch
from
f4fb6b8 to
4dc90a2
Compare
stevenbal
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414