Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#328] get specific object version #429

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Aug 2, 2024

Fixes #328

Changes

Allows retrieving objects by their uuid and index

@SonnyBA SonnyBA force-pushed the feature/328-get-specific-version branch from 78e92a9 to ddf3d80 Compare August 2, 2024 14:04
@SonnyBA SonnyBA marked this pull request as ready for review August 2, 2024 14:26
@SonnyBA SonnyBA self-assigned this Aug 2, 2024
src/objects/api/v2/openapi.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as Steven's. Otherwise looks good

@SonnyBA SonnyBA force-pushed the feature/328-get-specific-version branch from ddf3d80 to a9a808a Compare September 5, 2024 12:33
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (e97300f) to head (528a7d5).
Report is 129 commits behind head on master.

Files with missing lines Patch % Lines
src/objects/api/v2/views.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   94.84%   95.19%   +0.35%     
==========================================
  Files         135      152      +17     
  Lines        4657     5352     +695     
==========================================
+ Hits         4417     5095     +678     
- Misses        240      257      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal self-requested a review September 16, 2024 07:37
@SonnyBA SonnyBA merged commit 4f0789d into master Sep 16, 2024
12 checks passed
@SonnyBA SonnyBA deleted the feature/328-get-specific-version branch September 16, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a developer I would like to get a specific version of an object
4 participants