Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email environment variables #366

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Add email environment variables #366

merged 2 commits into from
Feb 26, 2024

Conversation

sjoerdie
Copy link
Contributor

@sjoerdie sjoerdie commented Feb 26, 2024 •
edited
Loading

Fix #321

Not sure if we want to use django_yubin.backends.QueuedEmailBackend as openforms e.g.

@sjoerdie sjoerdie requested a review from alextreme February 26, 2024 13:10
@alextreme
Copy link
Member

Not sure if we want to use django_yubin.backends.QueuedEmailBackend as openforms e.g.

This isn't possible, as yubin isn't part of the project (yet).

For @annashamray to approve as the Objects API isn't my project

annashamray
annashamray approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original bug was found in Objecttypes API
Could you make the similar PR in the Objecttypes repo also?

@sjoerdie sjoerdie merged commit 1b9b789 into maykinmedia:master Feb 26, 2024
5 checks passed
@sjoerdie
Copy link
Contributor Author

The original bug was found in Objecttypes API Could you make the similar PR in the Objecttypes repo also?

Yes, that was my plan, thank you.

@sjoerdie sjoerdie mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray approved these changes

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: password reset returns 500
3 participants
@sjoerdie @alextreme @annashamray