➕ Add django-log-outgoing-requests #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annashamray
requested changes
Mar 5, 2024
There was a problem hiding this comment.
- Let's have a global var LOG_REQUESTS which switches off and on the logging. You can take a look at the config of open zaak or open forms
- Let's turn off saving to the DB by default:
LOG_OUTGOING_REQUESTS_DB_SAVE = config("LOG_OUTGOING_REQUESTS_DB_SAVE", default=False)
Coperh
force-pushed
the
feature/add-django-log-outgoing-requests
branch
2 times, most recently
from
ac446d7 to
b946845
Compare
annashamray
reviewed
Apr 17, 2024
src/objects/conf/base.py
Outdated
Comment on lines
236
to
237
| LOG_REQUESTS = config("LOG_REQUESTS", default=False) | ||
| LOG_OUTGOING_REQUESTS_DB_SAVE = config("LOG_OUTGOING_REQUESTS_DB_SAVE", default=True) |
There was a problem hiding this comment.
Please add new env vars to the docs
There was a problem hiding this comment.
Added to docs/installation/config.rst
annashamray
reviewed
Apr 22, 2024
|
@annashamray there is an issue for it maykinmedia/open-api-framework#14 (and also for setup_configuration maykinmedia/open-api-framework#15) |
Coperh
force-pushed
the
feature/add-django-log-outgoing-requests
branch
from
5e3134c to
d02fe83
Compare
Coperh
force-pushed
the
feature/add-django-log-outgoing-requests
branch
from
d02fe83 to
db6c915
Compare
annashamray
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344
replacement for #345