Helm Chart Enhancements #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PGSSLMODE env-var gives the ability to influence which SSL-mode is used by the postgres client. See https://www.postgresql.org/docs/current/libpq-ssl.html for more info.
The chart-releaser action detects chart version bumps and will publish the chart to a GH Page accordingly. For more info: https://github.com/helm/chart-releaser-action
Ensure that the healthcheck sends the Host-header with 'objects' as value, so we can add it to AllowedHosts.
|
@annashamray would you perhaps be able to review this PR? |
|
@jordi-t I'll try to find someone to do it @joeribekker Do we use objects api helm charts anywhere? |
|
@sjoerdie can you check this please? |
|
@jordi-t Postgres and redis need to be bumped, other than that all enhancements work fine. @annashamray or @joeribekker, I do not have settings permissions in this repository, please follow Jordi's instructions and create the branch while your at it. |
sjoerdie
approved these changes
Aug 2, 2022
|
@sjoerdie Can you move this helm chart to https://github.com/maykinmedia/charts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several enhancements for the Objects-API Helm chart.
Please see the commit descriptions for details.
As for the chart-releaser (2720504), before merging to master, please make sure that you have created a
gh-pagesbranch and in the Repo'sSettings > Pagesyou've changed the Source Branch togh-pages. For more details see chart-releaser prerequisites.Afterwards the chart-releaser will detect any future changes in the chart and will publish the chart accordingly. This means a chart repo is available and
helm repo add objecttypes https://maykinmedia.github.io/objects-api/can be used.Testing
All enhancements have been successfully tested on the Gemeente Utrecht environment.