[#351] Only apply merge on partial updates

maykinmedia · Dec 27, 2023 · cdeb100 · cdeb100
1 parent ab5ef67
commit cdeb100
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/objects/api/serializers.py b/src/objects/api/serializers.py
@@ -127,14 +127,12 @@ def update(self, instance, validated_data):
         # object_data is not used since all object attributes are immutable
         object_data = validated_data.pop("object", None)
         validated_data["object"] = instance.object
-        # in case of PATCH
+        # version should be set
         if "version" not in validated_data:
             validated_data["version"] = instance.version
-            if "data" in validated_data:
-                # Apply JSON Merge Patch for record data
-                validated_data["data"] = merge_patch(
-                    instance.data, validated_data["data"]
-                )
+        if self.partial and "data" in validated_data:
+            # Apply JSON Merge Patch for record data
+            validated_data["data"] = merge_patch(instance.data, validated_data["data"])
 
         record = super().create(validated_data)
         return record