Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check idp availability #103

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented May 15, 2024

Part of #99

I realized that requests is a hard dependency after all, so we can provide a base implementation, with opt-in.

@sergei-maertens sergei-maertens force-pushed the feature/99-check-idp-availability branch from 10f19f3 to f0f2f98 Compare May 17, 2024 10:51
@sergei-maertens sergei-maertens requested a review from stevenbal May 17, 2024 10:52
@sergei-maertens sergei-maertens marked this pull request as ready for review May 17, 2024 10:52
@sergei-maertens sergei-maertens force-pushed the feature/99-check-idp-availability branch from f0f2f98 to b50d8d9 Compare May 17, 2024 10:55
Optionally, the OIDC init view can check the identity provider
availability before redirecting the user to it.
@sergei-maertens sergei-maertens force-pushed the feature/99-check-idp-availability branch from b50d8d9 to ddddcc2 Compare May 22, 2024 06:21
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@stevenbal stevenbal merged commit d4471a8 into master May 23, 2024
7 checks passed
@stevenbal stevenbal deleted the feature/99-check-idp-availability branch May 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants