Skip to content

Commit

Permalink
✨ [#65] Add functionality to make users superuser based on groups
Browse files Browse the repository at this point in the history
issue: #65
  • Loading branch information
stevenbal committed Dec 21, 2023
1 parent 7d57717 commit d7d1b85
Show file tree
Hide file tree
Showing 4 changed files with 62 additions and 0 deletions.
1 change: 1 addition & 0 deletions mozilla_django_oidc_db/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class OpenIDConnectConfigAdmin(DynamicArrayMixin, SingletonModelAdmin):
"sync_groups_glob_pattern",
"default_groups",
"make_users_staff",
"superuser_group_names",
)
},
),
Expand Down
19 changes: 19 additions & 0 deletions mozilla_django_oidc_db/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,30 @@ def update_user(self, user, claims):

user.save(update_fields=values.keys())

self.update_user_superuser_status(user, claims)

self.update_user_groups(user, claims)
self.update_user_default_groups(user)

return user

def update_user_superuser_status(self, user, claims):
"""
Assigns superuser status to the user if the user is a member of at least one
specific group. Superuser status is explicitly removed if the user is not or
no longer member of at least one of these groups.
"""
groups_claim = self.config.groups_claim
superuser_group_names = self.config.superuser_group_names

if groups_claim and superuser_group_names:
claim_groups = glom(claims, groups_claim, default=[])
if set(superuser_group_names) & set(claim_groups):
user.is_superuser = True
else:
user.is_superuser = False
user.save()

def update_user_groups(self, user, claims):
"""
Updates user group memberships based on the group_claim setting.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Generated by Django 3.2.18 on 2023-12-21 11:59

from django.db import migrations, models

import django_better_admin_arrayfield.models.fields


class Migration(migrations.Migration):
dependencies = [
(
"mozilla_django_oidc_db",
"0011_alter_openidconnectconfig_userinfo_claims_source",
),
]

operations = [
migrations.AddField(
model_name="openidconnectconfig",
name="superuser_group_names",
field=django_better_admin_arrayfield.models.fields.ArrayField(
base_field=models.CharField(
max_length=50, verbose_name="Superuser group name"
),
blank=True,
default=list,
help_text="If any of these group names are present in the claims upon login, the user will be marked as a superuser. If none of these groups are present the user will lose superuser permissions.",
size=None,
verbose_name="Superuser group names",
),
),
]
11 changes: 11 additions & 0 deletions mozilla_django_oidc_db/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,17 @@ class OpenIDConnectConfig(CachingMixin, OpenIDConnectConfigBase):
"users to login to the admin interface. By default they have no permissions, even if they are staff."
),
)
superuser_group_names = ArrayField(
verbose_name=_("Superuser group names"),
base_field=models.CharField(_("Superuser group name"), max_length=50),
default=list,
blank=True,
help_text=_(
"If any of these group names are present in the claims upon login, "
"the user will be marked as a superuser. If none of these groups are present "
"the user will lose superuser permissions."
),
)

class Meta:
verbose_name = _("OpenID Connect configuration")
Expand Down

0 comments on commit d7d1b85

Please sign in to comment.