💚 [#94] Update broken tests

Tests no longer reflected the current implementation.
maykinmedia · May 1, 2024 · 308e228 · 308e228
1 parent c391ccb
commit 308e228
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/tests/test_admin_form.py b/tests/test_admin_form.py
@@ -22,9 +22,9 @@ def test_derive_endpoints_success():
         "oidc_rp_sign_algo": "RS256",
         "oidc_op_discovery_endpoint": "http://discovery-endpoint.nl/",
         "claim_mapping": get_claim_mapping(),
-        "groups_claim": "roles",
+        "groups_claim": ["roles"],
         "sync_groups_glob_pattern": "*",
-        "username_claim": "sub",
+        "username_claim": ["sub"],
         "oidc_nonce_size": 32,
         "oidc_state_size": 32,
         "userinfo_claims_source": UserInformationClaimsSources.id_token,
@@ -71,9 +71,9 @@ def test_derive_endpoints_extra_field():
         "oidc_rp_sign_algo": "RS256",
         "oidc_op_discovery_endpoint": "http://discovery-endpoint.nl/",
         "claim_mapping": get_claim_mapping(),
-        "groups_claim": "roles",
+        "groups_claim": ["roles"],
         "sync_groups_glob_pattern": "*",
-        "username_claim": "sub",
+        "username_claim": ["sub"],
         "oidc_nonce_size": 32,
         "oidc_state_size": 32,
         "userinfo_claims_source": UserInformationClaimsSources.id_token,
@@ -119,9 +119,9 @@ def test_derive_endpoints_request_error(*m):
         "oidc_rp_sign_algo": "RS256",
         "oidc_op_discovery_endpoint": "http://discovery-endpoint.nl",
         "claim_mapping": get_claim_mapping(),
-        "groups_claim": "roles",
+        "groups_claim": ["roles"],
         "sync_groups_glob_pattern": "*",
-        "username_claim": "sub",
+        "username_claim": ["sub"],
         "oidc_nonce_size": 32,
         "oidc_state_size": 32,
         "userinfo_claims_source": UserInformationClaimsSources.id_token,
@@ -145,9 +145,9 @@ def test_derive_endpoints_json_error(*m):
         "oidc_rp_sign_algo": "RS256",
         "oidc_op_discovery_endpoint": "http://discovery-endpoint.nl",
         "claim_mapping": get_claim_mapping(),
-        "groups_claim": "roles",
+        "groups_claim": ["roles"],
         "sync_groups_glob_pattern": "*",
-        "username_claim": "sub",
+        "username_claim": ["sub"],
         "oidc_nonce_size": 32,
         "oidc_state_size": 32,
         "userinfo_claims_source": UserInformationClaimsSources.id_token,
@@ -169,9 +169,9 @@ def test_no_discovery_endpoint_other_fields_required():
         "oidc_rp_client_secret": "secret",
         "oidc_rp_sign_algo": "RS256",
         "claim_mapping": get_claim_mapping(),
-        "groups_claim": "roles",
+        "groups_claim": ["roles"],
         "sync_groups_glob_pattern": "*",
-        "username_claim": "sub",
+        "username_claim": ["sub"],
         "oidc_nonce_size": 32,
         "oidc_state_size": 32,
         "userinfo_claims_source": UserInformationClaimsSources.id_token,

diff --git a/tests/test_utils.py b/tests/test_utils.py
@@ -18,6 +18,7 @@ def test_obfuscate_non_string():
 def test_obfuscate_nested():
     claims = {
         "foo": "not_obfuscated",
+        "foo.bar": "obfuscated",
         "some": {
             "nested": {
                 "claim": "obfuscated",
@@ -29,9 +30,14 @@ def test_obfuscate_nested():
             "bar": "obfuscated",
         },
     }
-    claims_to_obfuscate = ["some.nested.claim", "object"]
+    claims_to_obfuscate = [
+        ["foo.bar"],
+        ["some", "nested", "claim"],
+        ["object"],
+    ]
     expected_result = {
         "foo": "not_obfuscated",
+        "foo.bar": "********ed",
         "some": {"nested": {"claim": "********ed", "claim2": "not_obfuscated"}},
         "object": {"foo": "********ed", "bar": "********ed"},
     }