Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support CMS 4 #1

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add support CMS 4 #1

merged 2 commits into from
Nov 6, 2024

Conversation

Coperh
Copy link
Collaborator

@Coperh Coperh commented Nov 4, 2024

  • Removes deprecated function in CMS4
  • Run tests with both Django3.2 and CMS 4
  • Added github aciton
  • Update semantics to minimum python 3.9, CMS 3.11

@Coperh Coperh force-pushed the feature/cms-4-support branch from bd52b83 to 6925fea Compare November 4, 2024 16:49
@Coperh
Copy link
Collaborator Author

Coperh commented Nov 5, 2024

This was pretty easy (most time fixing tox & CI). Plugins do not seem to change that much.

Most of the changes related to the Page and Title now PageContent

@Coperh Coperh force-pushed the feature/cms-4-support branch 2 times, most recently from 61633e0 to c988229 Compare November 5, 2024 14:13
@Coperh Coperh requested a review from alextreme November 5, 2024 14:39
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this was indeed a lot less problematic than expected (although blacking the modified files could have been done in a separate commit to ease reviewing)

@alextreme
Copy link
Member

Feel free to merge if you're ready and this is it

@Coperh Coperh force-pushed the feature/cms-4-support branch from c988229 to 687d9ed Compare November 5, 2024 15:52
@Coperh Coperh merged commit 15c0d14 into master Nov 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants