[#37] Explicitly handle transactions in the runner #38
Conversation
swrichards
force-pushed
the
runner-managed-db-transactions
branch
from
2ce6af9 to
a971f55
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 96.89% 97.37% +0.48%
==========================================
Files 8 24 +16
Lines 193 991 +798
==========================================
+ Hits 187 965 +778
- Misses 6 26 +20 ☔ View full report in Codecov by Sentry. |
swrichards
force-pushed
the
runner-managed-db-transactions
branch
2 times, most recently
from
b2feb26 to
521414b
Compare
swrichards
force-pushed
the
runner-managed-db-transactions
branch
from
521414b to
82b4035
Compare
| results.append(result) | ||
| yield result | ||
|
|
||
| if any(result.run_exception for result in results): |
There was a problem hiding this comment.
If I try this locally (for instance with Open Notificaties and have an incorrect service identifier) and add a breakpoint at line 227, the command output is:
CommandError: Error while executing step `Configuration for Notificaties API`: Service matching query does not exist. (identifier = incorrect)
And it seems that line 227 is never reached, probably because the entire thing crashes due to the CommandError which isn't caught. Is this a mistake in the implementation of the step in notifications_api_common or should that be handled here?
| return { | ||
| "transaction_test_configuration_enabled": True, | ||
| "transaction_test_configuration": {"username": "alice"}, | ||
| } | test_step_valid_config |
There was a problem hiding this comment.
I'm not familiar with this, isn't | an unsupported operand for two dicts?
Closes #37 .