✨ [#33] Add reset_db_save_after option to config model

[stevenbal]

closes #33

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.39%. Comparing base (704b1ae) to head (2220b2d).

Files	Patch %	Lines
log_outgoing_requests/admin.py	55.55%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   97.75%   97.39%   -0.36%     
==========================================
  Files          21       22       +1     
  Lines         445      461      +16     
  Branches       57       58       +1     
==========================================
+ Hits          435      449      +14     
- Misses          6        9       +3     
+ Partials        4        3       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

not sure how I can add the OutgoingRequestsLogConfig typehint here without the docs check failing, I tried it with if TYPE_CHECKING but that didn't work

[sergei-maertens]

from __future__ import annotations and then a conditional import tends to work usually, but instead, why not pass the self.reset_db_save_after so you can provide a typehint reset_after: int | None so you're only working in primitives :)

[alextreme]

Ziet er goed uit, wel graag een review van Sergei afwachten voor de zekerheid

[sergei-maertens]

There's also a disclaimer that you can only schedule tasks in the future as long as your broker remembers the tasks.

E.g. if you use Redis and you set the reset to 1 week, it's very likely that the key for that task has expired in redis before that moment arrives, so it will never be reset.

[sergei-maertens]

from __future__ import annotations and then a conditional import tends to work usually, but instead, why not pass the self.reset_db_save_after so you can provide a typehint reset_after: int | None so you're only working in primitives :)

[sergei-maertens]

I'd also add a min value validator to set at least 1 minute, 0 minutes would immediately reset it and makes it unclear in the code if the value is set to 0 or None with the soft-boolean check if config.reset_db_save_after

Adding the validator removes ambiguity

[sergei-maertens]

Suggested change

	"depending on the broker that is used, if this value is duration is too long "
	"the key for the reset task might have expired before that time. So make sure not to "
	"set too large a value for the reset."
	"depending on the broker that is used, if this duration is too long "
	"the key for the reset task might have expired before that time. So make sure not to "
	"set too large a value for the reset."

[sergei-maertens]

couple more things to polish but otherwise seems good to merge