🐛 [#34] Properly log data for error responses #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
issue/34-properly-log-values-for-error-responses
branch
from
f7f566b to
97ff931
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 21 21
Lines 445 445
Branches 57 57
=======================================
Hits 435 435
Misses 6 6
Partials 4 4 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
issue/34-properly-log-values-for-error-responses
branch
2 times, most recently
from
2f7fa5f to
bb2f31d
Compare
the handler previously did not log `status_code`, `response_ms` and `res_headers` because truthy checks on `Response` evaluate to false for error responses
stevenbal
force-pushed
the
issue/34-properly-log-values-for-error-responses
branch
from
bb2f31d to
3fb7733
Compare
sergei-maertens
approved these changes
Feb 8, 2024
my thoughts exactly 😛 |
stevenbal
deleted the
issue/34-properly-log-values-for-error-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34