Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move zgw-consumers-oas import to related function #50

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Move zgw-consumers-oas import to related function #50

merged 1 commit into from
Nov 29, 2024

Conversation

SonnyBA
Copy link

@SonnyBA SonnyBA commented Nov 29, 2024

See CI run, importing reverse from commonground-api-common.tests causes a ModuleNotFoundError because of the zgw_consumers_oas import statement. This requirement is optional and the change in this PR moves it to the function which actually requires the module.

@SonnyBA SonnyBA self-assigned this Nov 29, 2024
@SonnyBA SonnyBA mentioned this pull request Nov 29, 2024
Merged
@stevenbal
Copy link

@SonnyBA is this issue still relevant after this is merged? #49

@SonnyBA
Copy link
Author

SonnyBA commented Nov 29, 2024

@SonnyBA is this issue still relevant after this is merged? #49

Yeah whatever name we'll give the optional requirement, it should not be required to for example import the reverse function like linked above.

@SonnyBA SonnyBA merged commit 4034941 into main Nov 29, 2024
6 checks passed
@SonnyBA SonnyBA deleted the fix-zgw-consumers-oas-import branch November 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal approved these changes

@annashamray annashamray Awaiting requested review from annashamray

Assignees

@SonnyBA SonnyBA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SonnyBA @stevenbal