Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support 'allOf' and 'oneOf' in schema check #12

Merged
merged 3 commits into from
Sep 28, 2023
Merged

support 'allOf' and 'oneOf' in schema check #12

merged 3 commits into from
Sep 28, 2023

Conversation

annashamray
Copy link

@annashamray annashamray commented Sep 12, 2023 •
edited
Loading

Description:

The new ZGW standards include "oneOf" and "allOf" keywords, which are not currently supported. This PR takes care of it

@annashamray annashamray mentioned this pull request Sep 12, 2023
Merged
@annashamray annashamray changed the title ✨ support 'allOf' and 'oneOf' in schema check [WIP] support 'allOf' and 'oneOf' in schema check Sep 12, 2023
@annashamray annashamray changed the title [WIP] support 'allOf' and 'oneOf' in schema check support 'allOf' and 'oneOf' in schema check Sep 18, 2023
joeribekker
joeribekker approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not really "support" but rather ignore...

But, I guess for this purpose its fine.

@annashamray annashamray merged commit 3578b3c into main Sep 28, 2023
@Viicos Viicos deleted the feature/schema-validation-update branch February 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeribekker joeribekker joeribekker approved these changes

@sergei-maertens sergei-maertens Awaiting requested review from sergei-maertens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annashamray @joeribekker