♻️ - refactor: move filterTransform to DataGrid as prop #83
Conversation
There was a problem hiding this comment.
Maybe good to have a story where multiple fields need to be transformed?
There was a problem hiding this comment.
Yes, in general we better stories are useful. TBH I kinda rushed this in to fix our broken PR but better documentation is a good idea.
| name: "dateOfBirth", | ||
| type: "daterange", | ||
| }, | ||
| ], | ||
| filterable: true, | ||
| filterTransform: (data) => { |
There was a problem hiding this comment.
I am wondering: if I understand correctly, now we will have one function that has to handle the filters transform for all the fields. If that's the case, it could be harder to maintain than specifying the filters transform on the fields themselves 🤔
Maybe the filter transforms could still be specified per field and then when they need to be applied we could iterate over the fields that are active and pass to a filter the output of the previous one?
Also, how does this behave in the case of selectable columns when a particular field is disabled?
There was a problem hiding this comment.
I am wondering: if I understand correctly, now we will have one function that has to handle the filters transform for all the fields. If that's the case, it could be harder to maintain than specifying the filters transform on the fields themselves 🤔
Yes, as I there might be (rare) cases where another filter's value needs to be used as well.
Maybe the filter transforms could still be specified per field and then when they need to be applied we could iterate over the fields that are active and pass to a filter the output of the previous one?
Wouldn't this mean that the order the fields is affect the outcome? The order which is used for presentational purposes (and in the future maybe dynamic?
Also, how does this behave in the case of selectable columns when a particular field is disabled?
I'm not sure what you mean here but I think this is up to the user.
|
Merged in as considered hotfix |
No description provided.