Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react nodes in tabular layout #68

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

SilviaAmAm
Copy link
Contributor

No description provided.

If the items are objects and there are initial selected values that are not the same object (different reference) as the items in objectList, the selection didn't work
@SilviaAmAm SilviaAmAm force-pushed the feature/react-nodes-tabular-layout branch from 3ad95e6 to 03f225d Compare May 31, 2024 09:00
@SilviaAmAm SilviaAmAm marked this pull request as ready for review May 31, 2024 09:05
@SilviaAmAm SilviaAmAm requested a review from Xaohs May 31, 2024 09:05
@SilviaAmAm SilviaAmAm force-pushed the feature/react-nodes-tabular-layout branch from be41dc3 to 283b139 Compare June 3, 2024 10:53
Copy link
Collaborator

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion

src/lib/data/attributedata.ts Outdated Show resolved Hide resolved
@SilviaAmAm SilviaAmAm force-pushed the feature/react-nodes-tabular-layout branch from 283b139 to d4e17c2 Compare June 3, 2024 11:24
@SilviaAmAm SilviaAmAm force-pushed the feature/react-nodes-tabular-layout branch from d4e17c2 to 53be64c Compare June 3, 2024 11:29
@SilviaAmAm SilviaAmAm force-pushed the feature/react-nodes-tabular-layout branch from 53be64c to d4897e6 Compare June 3, 2024 11:56
@SilviaAmAm SilviaAmAm merged commit 5f8d71c into main Jun 3, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants