Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ #17 - feat: improved kanban #64

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented May 23, 2024

@Xaohs Xaohs marked this pull request as draft May 23, 2024 13:14
@Xaohs Xaohs requested a review from SilviaAmAm May 24, 2024 11:35
@Xaohs Xaohs marked this pull request as ready for review May 24, 2024 11:35
src/components/data/kanban/kanban.tsx Outdated Show resolved Hide resolved
src/components/data/kanban/kanban.tsx Show resolved Hide resolved
src/components/data/kanban/kanban.tsx Outdated Show resolved Hide resolved
src/components/data/kanban/kanban.tsx Outdated Show resolved Hide resolved
src/components/data/kanban/kanban.tsx Outdated Show resolved Hide resolved
src/components/data/kanban/kanban.tsx Show resolved Hide resolved
src/components/data/kanban/kanban.stories.tsx Outdated Show resolved Hide resolved
src/components/data/kanban/kanban.scss Show resolved Hide resolved
src/templates/kanban-template/kanban-template.stories.tsx Outdated Show resolved Hide resolved
src/templates/kanban-template/kanban-template.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure I understand how in the case of the drag and drop the item that has been moved can be updated in the backend. I don't see a mechanism yet to have a callback with the ID of the item that has been moved and the information that needs to be updated (the new status). Am I missing something?

src/templates/kanban-template/kanban-template.stories.tsx Outdated Show resolved Hide resolved
src/components/data/kanban/kanban.tsx Outdated Show resolved Hide resolved
@Xaohs Xaohs merged commit 5c5c9a8 into fixes/open-archiefbeheer May 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants