Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/login view #34

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Feature/login view #34

merged 8 commits into from
Feb 20, 2024

Conversation

svenvandescheur
Copy link
Collaborator

No description provided.

@svenvandescheur svenvandescheur force-pushed the feature/login-view branch 9 times, most recently from 0737f47 to e8135f1 Compare February 19, 2024 16:09
@svenvandescheur svenvandescheur marked this pull request as ready for review February 19, 2024 16:56
@svenvandescheur svenvandescheur force-pushed the feature/login-view branch 6 times, most recently from 76ce85b to 0b2f9b9 Compare February 20, 2024 13:53
Copy link

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small spelling mistake, but all else is just things-to-ponder, or simply accessibility stuff for the future.

src/components/form/formcontrol/formcontrol.stories.tsx Outdated Show resolved Hide resolved
src/components/form/select/select.scss Show resolved Hide resolved
src/templates/login/login.tsx Show resolved Hide resolved
src/components/data/paginator/paginator.scss Show resolved Hide resolved
src/components/form/.storybook/decorators.tsx Show resolved Hide resolved
src/components/form/select/select.tsx Show resolved Hide resolved
Copy link

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid.

@svenvandescheur svenvandescheur merged commit 3c3baa2 into main Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants