-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ #23 - feat: Implemented the items
prop for the toolbar a…
#15
Conversation
I found a loop in Storybook and wanted to avoid having to annotate props with a type, so i simplified the API a bit in favor inspecting the item shape to find the specific component to render. I did run into a circular import (Dropdown -> Toolbar -> Dropdown) when trying to facilitate dynamic creation of the Dropdown through items, I fixed this using a dynamic import and a state (a bit hacky but it seems to work).
|
a6522d1
to
fedef4b
Compare
@Xaohs I'm merging this to avoid future conflicts. If you find any issues with this please create an issue. |
✨ #15 - feat: implemented the breadcrumbs component
…nd its related components