Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ #23 - feat: Implemented the items prop for the toolbar a… #15

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Jan 24, 2024

…nd its related components

@Xaohs Xaohs self-assigned this Jan 24, 2024
@svenvandescheur
Copy link
Collaborator

I found a loop in Storybook and wanted to avoid having to annotate props with a type, so i simplified the API a bit in favor inspecting the item shape to find the specific component to render.

I did run into a circular import (Dropdown -> Toolbar -> Dropdown) when trying to facilitate dynamic creation of the Dropdown through items, I fixed this using a dynamic import and a state (a bit hacky but it seems to work).

  • Can you try to import the library (npm pack, npm install /path/to/archive.tar.gz) to check if this works in the real world? I
  • You might run into problems using the library since the path to index.js in package.json seems to be broken, you might need to alter it (dis/src/index.js?) to facilitate the former.

Xaohs pushed a commit that referenced this pull request Jan 26, 2024
Xaohs pushed a commit that referenced this pull request Jan 26, 2024
Xaohs pushed a commit that referenced this pull request Jan 26, 2024
@svenvandescheur svenvandescheur force-pushed the feature/#23-toolbar-items branch from a6522d1 to fedef4b Compare January 30, 2024 12:42
@svenvandescheur
Copy link
Collaborator

@Xaohs I'm merging this to avoid future conflicts. If you find any issues with this please create an issue.

@svenvandescheur svenvandescheur merged commit d1ddabd into main Jan 30, 2024
6 checks passed
svenvandescheur added a commit that referenced this pull request Feb 1, 2024
Xaohs pushed a commit that referenced this pull request Feb 2, 2024
svenvandescheur added a commit that referenced this pull request Feb 2, 2024
#15 - feat: implemented the breadcrumbs component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants