🐛 - fix: fixed the overlapping of the icon #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
requested changes
Oct 8, 2024
svenvandescheur
requested changes
Oct 11, 2024
| @@ -8,6 +8,11 @@ | |||
| width: 100%; | |||
| } | |||
|
|
|||
| .mykn-stackctx:has(.mykn-icon) .mykn-input, | |||
| .mykn-stackctx:has(.mykn-icon) .mykn-select { | |||
| padding-right: 30px; | |||
There was a problem hiding this comment.
This looks like a better approach.
can we however:
- Move this to
stackctx.scssso a widget directly rendered without Form(Control) gets the fix as well? - Use
padding-inline-endinstead ofpadding-right? - Add
box-sizing: border-box;to.mykn-stackctxto make sure the padding has as little effect on the width as possible?
svenvandescheur
force-pushed
the
issue/#132-placeholder
branch
from
495716d to
255ce8d
Compare
svenvandescheur
force-pushed
the
issue/#132-placeholder
branch
from
255ce8d to
0e68f18
Compare
svenvandescheur
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.