Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/datagrid design #127

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Issue/datagrid design #127

merged 4 commits into from
Aug 30, 2024

Conversation

svenvandescheur
Copy link
Collaborator

No description provided.

@svenvandescheur svenvandescheur requested a review from Xaohs August 30, 2024 09:49

// This is a hack, it prevents unintended overflowing in specific scenario's with DataGrid.
.mykn-column & + :last-child {
width: calc(100% - 40px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this responsive?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, that was a left over from an earlier attempt. I removed it (and yes it was responsive :P ).

Copy link
Contributor

@Xaohs Xaohs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just check if the width hack is actually responsive, and fix build ;)

@svenvandescheur svenvandescheur merged commit f5ab975 into main Aug 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants