✨ - feat: login page #118
Open
✨ - feat: login page #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Testing on Mobile and possible improvements for mobile |
svenvandescheur
requested changes
Aug 9, 2024
src/components/card/card.scss
Outdated
| } | ||
|
|
||
| &--shadow { | ||
| box-shadow: 0px 0px 10px 0.5px var(--page-color-shadow); |
There was a problem hiding this comment.
The shadow seems a bit heavy, can we make it more subtle?
src/templates/login/login.tsx
Outdated
| justify: true, | ||
| }} | ||
| /> | ||
| <P muted> |
There was a problem hiding this comment.
- The link should be customizable
- The P should only be shown when the link is provided.
| description: "templates.Login: The login title", | ||
| defaultMessage: "Welkom Terug", | ||
| }); | ||
|
|
There was a problem hiding this comment.
labelForgotPassword and I think one label (for both the title and link) should be sufficient, given that both the fallback and React Intl implementation support placeholders for values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.