Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 - fix: fixed button disabled visual #109

Merged
merged 1 commit into from
Jul 29, 2024
Merged

🎨 - fix: fixed button disabled visual #109

merged 1 commit into from
Jul 29, 2024

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Jul 19, 2024

No description provided.

@Xaohs Xaohs requested a review from svenvandescheur July 19, 2024 14:20
svenvandescheur
svenvandescheur requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ticket wasn't specced correctly: but the intended behavior here was AFAIK to have a primary disabled button appear as a standard (gray) button in disabled state.

@svenvandescheur svenvandescheur mentioned this pull request Jul 29, 2024
Closed
@svenvandescheur svenvandescheur force-pushed the issue/#200-disabled-button branch from b9ede24 to a67d452 Compare July 29, 2024 08:52
@svenvandescheur svenvandescheur force-pushed the issue/#200-disabled-button branch from a67d452 to 7b32a34 Compare July 29, 2024 08:56
@svenvandescheur svenvandescheur merged commit 86eb0c5 into main Jul 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvandescheur svenvandescheur svenvandescheur requested changes

@SilviaAmAm SilviaAmAm SilviaAmAm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xaohs @svenvandescheur @SilviaAmAm