Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk transaction deletion #845

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Jun 7, 2024

Continuation of #840

This PR includes:

  • Cleanup of the show.html.erb view for Transactions
  • Adds the ability for a user to delete transactions
    • Individually in transaction detail drawer
    • In bulk via bulk selection UI
CleanShot.2024-06-07.at.16.42.22.mp4

@zachgoll zachgoll linked an issue Jun 7, 2024 that may be closed by this pull request
4 tasks
@apply block bg-gray-100 w-9 h-5 rounded-full cursor-pointer;
@apply after:content-[''] after:block after:absolute after:top-0.5 after:left-0.5 after:bg-white after:w-4 after:h-4 after:rounded-full after:transition-transform after:duration-300 after:ease-in-out;
@apply peer-checked:bg-green-600 peer-checked:after:translate-x-4;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only net-new change. Everything else is class re-ordering.

assert_equal "CAD", transaction.currency
assert_equal Transaction::Category.second, transaction.category
end
end
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next PR will implement these bulk updates. Leaving this here as a placeholder.

@zachgoll zachgoll merged commit d3f9be1 into main Jun 7, 2024
4 checks passed
@zachgoll zachgoll deleted the 832-ability-to-delete-and-bulk-delete-transactions branch June 7, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Delete and Bulk Delete Transactions
1 participant