Make encryption config optional for self hosting users #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
Nov 18, 2024
| session.delete(:return_to) | ||
| redirect_to fallback_path | ||
| end | ||
| end |
There was a problem hiding this comment.
Unrelated, fixes a bug where clicking "back" from settings throws a 404 when the "return to" path is the URL of a resource that has been deleted from /accounts page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the Maybe app, the encryption module is used in a very narrow scope—for properly storing access tokens for Plaid Items.
Given that self hosters will generally not be managing their own Plaid setup, they will not need the encryption module for a functioning app. The configuration for this module adds quite a bit of overhead to the initial setup for self hosters, so this PR makes it entirely optional. We can adjust this in the future if encryption becomes mandatory for self hosters, but I do not foresee that becoming an issue for quite some time.