Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration fails silently when there are errors #1455

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

tonyvince
Copy link
Contributor

Fix #1443

Screenshot 2024-11-11 at 11 17 11

Copy link

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested for the password_field on line 35

<%= form.password_field :password, autocomplete: "new-password", required: "required", label: true %>

  <%= form.password_field :password, autocomplete: "new-password", required: "required", label: true, :maxlength => 75 %>

based on https://github.com/rails/rails/blob/1dd82aba340e8a86799bd97fe5ff2644c6972f9f/actionview/lib/action_view/helpers/tags/text_field.rb#L13

my ruby isn't up to standards so please double check the syntax

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@zachgoll zachgoll merged commit 278d04a into maybe-finance:main Nov 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Registration fails silently with long passwords
3 participants