Final cleanup

maybe-finance · Jun 13, 2024 · 9f24f7d · 9f24f7d
1 parent 54af86b
commit 9f24f7d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb
@@ -25,7 +25,7 @@ def list
   def new
     @account = Account.new(
       balance: nil,
-      accountable: Accountable.from_type(params[:type])&.new,
+      accountable: Accountable.from_type(params[:type])&.new
     )
 
     if params[:institution_id]

diff --git a/app/controllers/institutions_controller.rb b/app/controllers/institutions_controller.rb
@@ -7,20 +7,20 @@ def new
 
   def create
     Current.family.institutions.create!(institution_params)
-    redirect_to accounts_path, notice: "Institution created"
+    redirect_to accounts_path, notice: t(".success")
   end
 
   def edit
   end
 
   def update
     @institution.update!(institution_params)
-    redirect_to accounts_path, notice: "Institution updated"
+    redirect_to accounts_path, notice: t(".success")
   end
 
   def destroy
     @institution.destroy!
-    redirect_to accounts_path, notice: "Institution deleted"
+    redirect_to accounts_path, notice: t(".success")
   end
 
   private

diff --git a/app/views/accounts/_institution_accounts.html.erb b/app/views/accounts/_institution_accounts.html.erb
@@ -26,7 +26,6 @@
           <span><%= t(".add_account_to_institution") %></span>
         <% end %>
 
-
         <%= link_to edit_institution_path(institution),
                     class: "block w-full py-2 px-3 space-x-2 text-gray-900 hover:bg-gray-50 flex items-center rounded-lg",
                     data: { turbo_frame: :modal } do %>

diff --git a/config/locales/views/institutions/en.yml b/config/locales/views/institutions/en.yml
@@ -7,3 +7,9 @@ en:
       name: Financial institution name
     new:
       new_institution: New financial institution
+    create:
+      success: "Institution created"
+    update:
+      success: "Institution updated"
+    destroy:
+      success: "Institution deleted"