Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unambig #15

Merged
merged 17 commits into from
Sep 16, 2024
Merged

Unambig #15

merged 17 commits into from
Sep 16, 2024

Conversation

stschaef
Copy link
Collaborator

No description provided.

@stschaef stschaef linked an issue Sep 16, 2024 that may be closed by this pull request
@maxsnew
Copy link
Owner

maxsnew commented Sep 16, 2024

Is this ready? It's not building

@stschaef
Copy link
Collaborator Author

It should be ready. It's passing locally and I have no diffs from the remote.

I think I may have accidentally re-run old workflows (on older commits) instead of on the head. Running again now to be sure

@maxsnew
Copy link
Owner

maxsnew commented Sep 16, 2024

It's showing some error to do with opaque:

/home/runner/work/grammars-and-semantic-actions/grammars-and-semantic-actions/code/cubical/NFA/Regex/Combinators.agda:218,15-18
warning: -W[no]UnfoldTransparentName
The name _⊕_, mentioned by an unfolding clause, does not belong to
an opaque block. This has no effect.
when scope checking the declaration
  import NFA.Regex.Combinators as .#NFA.Regex.Combinators-13138820953506565994
make: *** [Makefile:16: quicktest] Error 1

@maxsnew
Copy link
Owner

maxsnew commented Sep 16, 2024

Also, please give more descriptive names and a short description to your PRs. This PR also makes a huge change which is to make stuff opaque which I only noticed because of the CI failure

@stschaef
Copy link
Collaborator Author

It's showing some error to do with opaque:

/home/runner/work/grammars-and-semantic-actions/grammars-and-semantic-actions/code/cubical/NFA/Regex/Combinators.agda:218,15-18
warning: -W[no]UnfoldTransparentName
The name _⊕_, mentioned by an unfolding clause, does not belong to
an opaque block. This has no effect.
when scope checking the declaration
  import NFA.Regex.Combinators as .#NFA.Regex.Combinators-13138820953506565994
make: *** [Makefile:16: quicktest] Error 1

This error makes no sense though, as this definition is opaque.

What I meant was that the CI ran on a commit before sum was made opaque, and I made the mistake of re-running that job rather than spawning a new one on the new commit. So I believe that the current commit will build and I'd been running the wrong job

@maxsnew
Copy link
Owner

maxsnew commented Sep 16, 2024

Ok it's not erroring locally for me either so I'll merge

@maxsnew maxsnew merged commit 600b674 into main Sep 16, 2024
2 of 4 checks passed
@maxsnew maxsnew deleted the unambig branch September 16, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define unambguity
2 participants