Add tests for quick_tags and fix failing tags tests

maxmarcon · Dec 12, 2024 · 4717fbf · 4717fbf
1 parent 3db95ff
commit 4717fbf
Show file tree

Hide file tree

Showing 3 changed files with 537 additions and 5 deletions.
diff --git a/lib/live_select/component.ex b/lib/live_select/component.ex
@@ -435,13 +435,13 @@ defmodule LiveSelect.Component do
          extra_params
        )
        when active_option >= 0 do
-    option = Enum.at(socket.assigns.options, active_option)
+    option = Enum.at(options, active_option)
 
     if already_selected?(option, selection) do
       pos = get_selection_index(option, selection)
       unselect(socket, pos)
     else
-      select(socket, Enum.at(socket.assigns.options, socket.assigns.active_option), extra_params)
+      select(socket, Enum.at(options, active_option), extra_params)
     end
   end
 
@@ -710,7 +710,6 @@ defmodule LiveSelect.Component do
   defp next_selectable(%{
          options: options,
          active_option: active_option,
-         selection: selection,
          mode: :quick_tags
        }) do
     options
@@ -739,7 +738,6 @@ defmodule LiveSelect.Component do
   defp prev_selectable(%{
          options: options,
          active_option: active_option,
-         selection: selection,
          mode: :quick_tags
        }) do
     options

diff --git a/lib/live_select/component.html.heex b/lib/live_select/component.html.heex
@@ -124,7 +124,7 @@
                   )
                 )
             }
-            data-idx={idx}
+            data-idx={if @mode == :quick_tags or not already_selected?(option, @selection), do: idx}
           >
             <%= if @option == [] do %>
               <%= option.label %>