fix bestTrophies and threeCrownWins

README.md

@@ -61,6 +61,10 @@ client.getPlayerRanks('2023-03')
 
 > Get a list of all locations in the game
 
+* **getClan**(tag)
+
+> Get all information about a specific clan
+
 * **getClanRanks**(locationId, clanWars = false, limit = undefined)
 
 > Get a ranking of all clans in a certain location, either by clan ranking or by clan-war ranking 

clan.js

@@ -0,0 +1,41 @@
+class Clan {
+    constructor(tag, name, type, description, badgeId, clanScore, clanWarTrophies, location, requiredTrophies, donationsPerWeek, members, memberList) {
+        this.tag = tag;
+        this.name = name;
+        this.type = type;
+        this.description = description;
+        this.badgeId = badgeId;
+        this.clanScore = clanScore;
+        this.clanWarTrophies = clanWarTrophies;
+        this.location = location;
+        this.requiredTrophies = requiredTrophies;
+        this.donationsPerWeek = donationsPerWeek;
+        this.members = members;
+        this.memberList = memberList;
+    }
+
+    static fromJSON(jsonObject) {
+        return new Clan(
+            jsonObject.tag,
+            jsonObject.name,
+            jsonObject.type,
+            jsonObject.description,
+            jsonObject.badgeId,
+            jsonObject.clanScore,
+            jsonObject.clanWarTrophies,
+            jsonObject.location,
+            jsonObject.requiredTrophies,
+            jsonObject.donationsPerWeek,
+            jsonObject.members,
+            jsonObject.memberList
+        );
+    }
+
+    toString() {
+        return this.name;
+    }
+
+}
+
+
+module.exports = {Clan};

client.js

@@ -2,6 +2,7 @@ const { Connector} = require('./connector');
 const { Card } = require('./card');
 const { ChallengeView } = require('./challenge');
 const { Player } = require('./player');
+const { Clan } = require('./clan');
 const { BattleLog } = require('./battle');
 const { Location, ClanRanking } = require('./location');
 const { PlayerRanking } = require('./season');
@@ -65,6 +66,13 @@ class Client {
             .map(Location.fromJSON);
     }
 
+    async getClan(tag) {
+        // Allow getClan to be called on a tagged object
+        tag = this.argumentToString(`getClan(${tag})`, tag, 'tag');
+        const clan = await this.connector.request(['clans', tag]);
+        return Clan.fromJSON(clan);
+    }
+
     async getClanRanks(locationId, clanWars = false, limit = undefined) {
         // Allow getClanRanks to be called on an identified object
         locationId = this.argumentToString(`getClanRanks(${location}, ${clanWars}, ${limit})`, locationId, 'id');

player.js

@@ -111,8 +111,8 @@ class LeagueStats {
 }
 
 class Player {
-    constructor(tag, name, expLevel, expPoints, totalExpPoints, starPoints, trophies, trophyRecord,
-                battleCount, wins, threeCrowns, losses, challengeCardsWon, challengeBattleCount,
+    constructor(tag, name, expLevel, expPoints, totalExpPoints, starPoints, trophies, bestTrophies,
+                battleCount, wins, threeCrownWins, losses, challengeCardsWon, challengeBattleCount,
                 tournamentCardsWon, tournamentBattleCount, role, donations, donationsReceived,
                 totalDonations, warDayWins, clanCardsCollected, clan, arena, leagueStats,
                 badges, achievements, cards, favouriteCard) {
@@ -123,11 +123,12 @@ class Player {
         this.totalExpPoints = totalExpPoints;
         this.starPoints = starPoints;
         this.trophies = trophies;
-        this.trophyRecord = trophyRecord;
+        this.bestTrophies = bestTrophies;
         this.battleCount = battleCount;
         this.wins = wins;
-        this.threeCrowns = threeCrowns;
+        this.threeCrownWins = threeCrownWins;
         this.losses = losses;
+        this.draws = battleCount - (wins + losses);
         this.challengeCardsWon = challengeCardsWon;
         this.challengeBattleCount = challengeBattleCount;
         this.tournamentCardsWon = tournamentCardsWon;
@@ -156,10 +157,10 @@ class Player {
             jsonObject.totalExpPoints,
             jsonObject.starPoints,
             jsonObject.trophies,
-            jsonObject.trophyRecord,
+            jsonObject.bestTrophies,
             jsonObject.battleCount,
             jsonObject.wins,
-            jsonObject.threeCrowns,
+            jsonObject.threeCrownWins,
             jsonObject.losses,
             jsonObject.challengeCardsWon,
             jsonObject.challengeBattleCount,
@@ -171,7 +172,7 @@ class Player {
             jsonObject.totalDonations,
             jsonObject.warDayWins,
             jsonObject.clanCardsCollected,
-            jsonObject.clan ? jsonObject.clan.name : 'not in a clan',
+            jsonObject.clan ? jsonObject.clan.name : 'Sin clan',
             jsonObject.arena.name,
             LeagueStats.fromJSON(jsonObject.leagueStatistics),
             jsonObject.badges.map(Badge.fromJSON),