Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vulkan.rs (for updating ash v0.38) #117

Closed
wants to merge 1 commit into from

Conversation

Rishik-Y
Copy link
Contributor

Thanks for accepting the pull request before.

It's been a month, and I, unfortunately, had exams at my college and other events, so I couldn't contribute much here.

Anyway,
I updated a lot of code to be compatible with Ash v0.38 (in the future).
Sorry if It appears rude, but
Please, for the love of god, check the code once because this time, I genuinely do not even know what I did here.

All I know is that I just continuously fixed all errors and brought down errors from 200 to 20 (when using ash ~v0.38)
I Refactored the code to ensure it works with the current version of ash. (ash ~v0.37)

I just wanted a Confirmation from you whether I messed up somewhere because, as far as I tried, it worked fine for me.

Please Take your time, you don't have to immediately do it.

I updated a lot of code to be compatible with Ash v0.38 (in the future). 

Refactored code to ensure it works with the current version of ash.
@maximbaz
Copy link
Owner

Just an idea, what if you actually update ash here and we try to solve all the compile errors at once? Just wondering if you trying to find code that works on both versions adds additional unnecessary complexity...

For example, for new version of ash, I suspect (but not sure) that instead of map_err(...) you could have just used into(), but that doesn't work for ash 0.37 so I didn't suggest it

@Rishik-Y
Copy link
Contributor Author

Yeah, I have done just that today,
Just now changed even more code and successfully updated ash to v0.38 but again same as previous issue, I don't know how much I deviated from the original code.

I will close this pull request because i didn't check the make lint
and create a different pull request with my latest changes.

@Rishik-Y Rishik-Y closed this Sep 15, 2024
@Rishik-Y Rishik-Y deleted the patch-1 branch September 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants