Allow adding headers to generated fakes #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoegaarden
force-pushed
the
headers
branch
5 times, most recently
from
7cec59a to
67e3ef5
Compare
generator/file_reader.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| MaxHeaderBytes = 50 * 1024 // 50kb for the header should be enough? |
There was a problem hiding this comment.
This seems like an unnecessary optimization. At a minimum, I would want to make it so large as to be somewhat ridiculous.
When the `-header` flag is specified and is a valid file path, the content of that file will be prepended to the generated fake. This is useful for e.g. specify a licence header. The header flag can be specified in the `go:generate` and the `counterfeiter:generate` line or in both, where the later takes precedence over the former.
|
@joefitzgerald I removed the limit on the header's size. /PTAL |
|
I just had to wrestle with the same problem and ended up hacking around the lack of this feature: https://github.com/benmoss/cluster-api/blob/3ff999ed3eabc2ad9976e024418a6d71455af19d/hack/add-mock-boilerplate.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
-headerflag is specified and is a valid file path, thecontent of that file will be prepended to the generated fake. This is
useful for e.g. specify a licence header.
The header flag can be specified in the
go:generateand thecounterfeiter:generateline or in both, where the later takesprecedence over the former.
This is an attempt to address #98 (comment).