-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Return size in write functions #96
Conversation
It appears that something is wrong with GitHub, I can't get the "approve and run" button to work since it redirects to page 500 error. Will try again later. |
Can't get it to work for me either not sure what's going on. |
Same, does not work. You might have to contact github. |
I opened a support ticket with GitHub, I'll post back |
@patrickelectric not sure if #97 helped unblock things or if my support ticket, but CI is running, but failing, on an error that I can't really understand, I'll leave it to someone smarter than me to figure it out |
@nmsv looks like CI is reporting a real error
|
@mrpollo I'm able to reproduce the failed test on master (91f3966): |
Merged in #100 |
Returning size of written payload is usually a sane thing to do. Shouldn't hurt anyone.