Restructure project to enable custom mavlink bindings generation #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the project into three crates: * mavlink-core: core MAVLink types including TCP, UDP and serial connections * mavlink-bindgen: a library & CLI for generating Rust bindings for MAVLink dialects * mavlink: generated MAVLink bindings for the MAVLink dialects in the mavlink/mavlink repo
The mavlink-bindgen crate does not itself need to run on embedded hardware
|
This now passes all checks in my fork, so is ready for review @patrickelectric . The biggest change here is refactoring the crate into 3 crates in a single cargo workspace (which I think is required to supporting custom dialects). I'm happy to discuss alternative approaches or structures of a cargo workspace. Thanks! |
|
That looks awesome, thanks @GrahamDennis. I'll review asap. |
patrickelectric
requested changes
Feb 17, 2024
GrahamDennis
commented
Feb 18, 2024
patrickelectric
approved these changes
Feb 18, 2024
|
This change broke two links in the main README to the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enable generating Rust MAVLink bindings from custom MAVLink dialects in new crates. This is done by splitting the project into three crates:
mavlink-bindgen can be used to create MAVLink bindings for Rust, and this is used from
build.rsin themavlinkcrate to create bindings from the standard MAVLink dialects in https://github.com/mavlink/mavlink.The
mavlinkcrate is intended to remain API-compatible with the previous structure.