Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible with Asset.timestamp #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compatible with Asset.timestamp #24

wants to merge 2 commits into from

Conversation

johnjcamilleri
Copy link
Contributor

Here's my attempt to make Minify work with Asset.timestamp. If the URLs from assetURL contain timestamps then it strips them all out, but remembers the largest one and appends it to the end of the URL to Minify. Possible problems:

  1. Is it expensive to use regex here?
  2. Not entirely robust, the regex might match even when not using timestamps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnjcamilleri