Skip to content

Commit

Permalink
fixup, maybe
Browse files Browse the repository at this point in the history
  • Loading branch information
matzf committed Jul 15, 2024
1 parent 1e2d1af commit 48fd7d1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ jobs:
echo "Check that PR is of the form `<subystem>: <lowercase message>` :monocle_face:" >> $GITHUB_STEP_SUMMARY
url='https://docs.scion.org/en/latest/dev/git.html#good-commit-messages'
if [[ ! "$TITLE" =~ ^[a-z0-9,/]*:[[:space:]] ]]; then
echo "::warning {The PR title should start with `<substystem>: `.\nSee $url}"
echo "::warning {The PR title should start with `<substystem>: `.<br>See $url}"
exit 1
fi
# Title should be lower case; initialisms and identifiers still occur occasionally and should be allowed.
# -> enforce only the first word
if [[ ! "$TITLE" =~ ^[a-z0-9,/]*:[[:space:]][a-z] ]]; then
echo "::warning {The PR title should be lower case. (Enforced on first letter)\nSee $url}"
echo "::warning {The PR title should be lower case. (Enforced on first letter).<br>See $url}"
exit 1
fi
if [[ $TITLE =~ \.[[:space:]]*$ ]]; then
echo "::warning {The PR title should not end with a \".\".\nSee $url}"
echo "::warning {The PR title should not end with a \".\".<br>See $url}"
exit 1
fi

0 comments on commit 48fd7d1

Please sign in to comment.