attempt to deal with variable access to buckets #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the user only has access to specific buckets, this variable may be customized.
A single prefix was too restrictive. This change introduces `s3ed-bucket-list', a list of buckets that one has access to (default empty list). Use M-n/p to access contents of the list. The implementation is not great. Elements of the list are presented for `current-s3-base-path' in `s3ed-find-file' before the `s3ed-completing-read'. This is to avoid `s3ed-completing-read' from erroring out when an inaccessible bucket is in the minibuffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3ed always errors out if
s3://is the only thing in the minibuffer, or if I don't have access to the bucket in question.This is an attempt (though not pretty) to get around that limitation. If the current buffer is not an s3ed buffer, then instead of prepping the
s3ed-completing-readwith a bares3://, I've inserted acompleting-readto setcurrent-s3-base-pathfrom choices froms3ed-bucket-list.Another way to deal with this is to change
s3ed-completing-readto catch the "AccessDenied" errors.