This repository has been archived by the owner on Mar 12, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
can not pass with "groups" in yaml file #90
Open
Nidhoggur1993
wants to merge
15
commits into
mattray:master
Choose a base branch
from
Roddd:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Quote the "*" wildcard used in the examples and README. * Rescue the YAML exception.
- Chased down a bug that was causing the --extractyaml and --extractjson commands to output a data_bags section that was not complete. This issue was due to modification of the lists that are passed down to the data bag parsing class. Fixed by creating a "deep copy" (using Marshal) of the inputs structure and passing references to that copy. This keeps the original inputs intact. - Removed all occurences of the hash key "data bags" (with a space). Changed them all to "data_bags". I don't like spaces in hash keys if I can help it. - Changed some debugging to add spaces between printed items.
- The node yaml/json format has been extended to allow for a more human friendly format. - Parallel options removed. - Added pre-chef-10 knife command format. (How roles were passed had to be updated) TODO: Documentation needs to be updated.
- changed the way the chef 10 role string is generated. - Documentation update started.
- In order to clean up support for chef-pre-10 knife strings, the run_list should be in the config as a list from now on.
- The "host" directive has been added which will allow setting the bootstrap target to an IP or hostname different from the "name" directive. - Updated README with documentation on my yaml/json data structure changes and requirements.
- The "host" directive has been added which will allow setting the bootstrap target to an IP or hostname different from the "name" directive. - Updated README with documentation on my yaml/json data structure changes and requirements.
- Validation is now an option. It doesn't do it by default. - Added support for sec groups. You don't have to put them in the options section. The script will do that for you. - Grafted in the {{n}} support for node names from the main project. - Added an "availability_zone" directive to node sections to support distributing nodes across AZ's. - Added support to alternate AZ's when generating nodes of the same type. - Disabled delete command generation for the time being. It needs work.
Conflicts: lib/spiceweasel/node_list.rb
I'd be happy to include this fix and put out a refreshed version if you could rebase your patch to the current master 2.8 release. Thanks in advance! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like knife has changed it rule for the "The security groups for this server" from -g to -G.
So is it possible to make spiceweasel assemble the "groups" as -G?