Add Support for input_number domain #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outstanding bug: Rounding error when input_number step is set to certain values (observed easily with step set to 2 or 3)
|
was just about to suggest this! |
the step and the max of an input_number entity. Appears that at this time applyStep() is unnecessary, and was in fact causing the problem I have tested stepped sliders of both input_number entities as well as light and climate entities, and stepping still works as expected when applyStep() is not called at all. This does not resolve the issue where step count results in "illegal" values on certain input_number entities.
|
I wish this will be available soon. I'm real waiting for this. This add-on is wonderfull. |
|
If I understand well, the fonction is ready with a minor bug. Can you merge it in a beta we can try it ? |
|
May this pull be merged? Looks like a very nice feature. Thank you very much Liz! |
|
PR submitted to maintained version of slider-button-card custom-cards#7 |
|
How should be used? I am trying to add an input_number but I get error, like does not exists... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested in issues #161 and #7
This adds support for the input_number domain and makes the entities far far easier to manage on a mobile touch display vs. the builtin entities card.
One note: There is a current oustanding bug where if the input_number.entity.min value is not cleanly divisible by the input_number.entity.step value, then the slider card is off by an amount. If your input_number has min = 5, max = 25, step = 5 then it will work just fine. But if the step is 2, then it will be off. This also has the side effect of changing the input_number to an "illegal" value when modified via slider-button-card. Step = 1 always works.
If anyone has any insight I would appreciate the help. Otherwise, I am submitting as is, because it is largely functional right now.