Migrate to github.com/grafana/pyroscope-go/godeltaprof #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2023
streamer45
approved these changes
Oct 3, 2023
streamer45
added
3: Reviews Complete
|
@hanzei Will need you to send a signed commit or it won't let us merge. |
hanzei
force-pushed
the
github.com/grafana/pyroscope-go/godeltaprof
branch
from
aecbbdc
to
1132795
Compare
|
@streamer45 Do we need a new release? |
At some point yes, I'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
github.com/pyroscope-io/godeltaprof is no longer maintained and has been replace by https://github.com/grafana/pyroscope-go/tree/main/godeltaprof. Given that github.com/pyroscope-io/godeltaprof doesn't compile on
go1.21it's necessary to migrate to https://github.com/grafana/pyroscope-go/tree/main/godeltaprof.Ticket Link
mattermost/actions#13