Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-61122] Add diagnostics data to the Support Packet #904

Merged
merged 9 commits into from
Dec 10, 2024
Merged

[MM-61122] Add diagnostics data to the Support Packet #904

merged 9 commits into from
Dec 10, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Nov 11, 2024

Summary

When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.

Example content of com.mattermost.calls/diagnostics.yaml:

version: 1.2.0+b5a4211
total_calls: 1
total_active_calls: 1
total_active_sessions: 2
avg_duration: 51
avg_participants: 2

Requires mattermost/mattermost#28833 on the server side.

See https://mattermost.atlassian.net/wiki/spaces/CLOUD/pages/3083108354/Diagnostics+data+from+Core+Plugins+to+the+Support+Packet for more context.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61122

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 11, 2024
streamer45
streamer45 reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanzei . A couple of comments below.

server/support_packet.go Outdated Show resolved Hide resolved
server/support_packet.go Outdated Show resolved Hide resolved
@streamer45 streamer45 added this to the v1.4.0 / MM v10.4 milestone Nov 20, 2024
@hanzei hanzei requested a review from streamer45 November 21, 2024 17:35
streamer45
streamer45 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@hanzei hanzei added the 2: QA Review Requires review by a QA tester label Nov 22, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Dec 4, 2024

@wiggin77 Gentle reminder to review the PR 😉

wiggin77
wiggin77 reviewed Dec 4, 2024
View reviewed changes
server/support_packet.go Outdated Show resolved Hide resolved
wiggin77
wiggin77 reviewed Dec 4, 2024
View reviewed changes
server/support_packet.go Outdated Show resolved Hide resolved
wiggin77
wiggin77 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor change request.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Dec 5, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Dec 10, 2024

Per discussion with @raghavaggarwal2308, QA testing will happen post-merge.

@hanzei hanzei added 3: Reviews Complete All reviewers have approved the pull request and removed 2: QA Review Requires review by a QA tester labels Dec 10, 2024
@hanzei hanzei merged commit fef920d into main Dec 10, 2024
18 checks passed
@hanzei hanzei deleted the MM-61122_support-packet branch December 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@streamer45 streamer45 streamer45 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.4.0 / MM v10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @streamer45 @wiggin77