MM-61822 Fix the boards LHS and channel RHS boards channel memeber permission issue. #37
Conversation
Rajat-Dabade
added
2: Dev Review
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if user.IsGuest { |
There was a problem hiding this comment.
This is incorrect, we need to return explicitMembers not members if user is guest.
Also, lets move this check to before we fetch the synthetic board memberships.
There was a problem hiding this comment.
At this point, member contains only explicitMembers, but yes, you are correct that it should be moved before fetching the synthetic board members.
Done ✅
|
Other than the one comment, it works perfectly locally. |
Rajat-Dabade
force-pushed
the
permission-issue
branch
from
e8ce003 to
f6892d8
Compare
@harshilsharma63 Server tests are not configured yet in this repo because it was causing some issues (related to the plugin which needs MM table migration), Maybe this open source Friday I will look into this and then I can add a test for these file changes as well. |
Would those tests possibly have caught this issue before? If we aren't able to run existing tests, that seems like something we should see about getting you some non-OSF time to work on |
There was a problem hiding this comment.
It's pretty weird to me that the old code handled explicit and implicit members in separate packages there. I would've expected that to be done in one place, but I guess there were good reasons to do that. I notice that we seem to also be mixing the terms "implicit" and "synthetic" for those as well, but those both sound nicer than the "fake" channels term that we use in the web app 😛
This looks good to me, although the lack of tests for this code is concerning
|
@hmhealey I will try to fix the server test issue in this OSF or maybe will create a ticket to get it done. |
Rajat-Dabade
added
4: Reviews Complete
Summary
This PR addresses a regression where channel members could not see boards linked to the channel in the channel's board RHS or the boards LHS. The issue occurred because boards only checked for board membership, which previously relied on
Mattermost's auth layer. When the auth layer was removed during the plugin refactoring, the related code was lost.This fix ensures channel members can now see linked boards in both the channel RHS and the boards LHS. Additionally, I reviewed the removed
Mattermost auth layercode and restored all the missing functionality in this PR.Ticket Link
https://mattermost.atlassian.net/browse/MM-61822